Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List optional dependencies in pyproject (apart from docs and tests) #7563

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

radarhere
Copy link
Member

In thinking about #7502, it occurred to me that listing olefile and defusedxml as optional dependencies in pyproject.toml is probably helpful, as a form of documentation.

@hugovk
Copy link
Member

hugovk commented Nov 20, 2023

Sounds reasonable, people will be able to install like this:

python -m pip install pillow[fpx_mic]  # also installs olefile
python -m pip install pillow[xmp]      # also installs defusedxml

Shall we replace fpx_mic with fpx and mic?

python -m pip install pillow[fpx]  # also installs olefile
python -m pip install pillow[mic]  # also installs olefile
python -m pip install pillow[xmp]  # also installs defusedxml

Let's bikeshed now, because if we change it later, some may see it as a breaking change :)

@hugovk hugovk added the Installation Usually a problem with … label Nov 20, 2023
@radarhere radarhere merged commit a1d2297 into python-pillow:main Nov 28, 2023
56 checks passed
@radarhere radarhere deleted the optional-dependencies branch November 28, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Installation Usually a problem with …
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants